serial: enforce all traits have the same Error type.#337
Merged
Conversation
|
r? @ryankurte (rust-highfive has picked a reviewer for you, use r? to override) |
Dirbaio
force-pushed
the
serial-error-unify
branch
from
6307a1c to
5b5c791
Compare
Dirbaio
force-pushed
the
serial-error-unify
branch
from
5b5c791 to
66b27e4
Compare
Member
Author
|
Rebased on latest master. Friendly ping @eldruin @therealprof @ryankurte are there any pending concerns on this? |
therealprof
approved these changes
Jan 12, 2022
therealprof
left a comment
therealprof
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks. I've a feeling this might conflict now, though.
bors r+
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Equivalent of #331 for serial.